From: Florian Müllner <fmuellner@gnome.org>
Date: Wed, 25 Jun 2025 11:53:50 +0000 (+0200)
Subject: popupMenu: Use SEPARATOR a11y role for SeparatorMenuItems
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~124^2^2~23
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=eb98f88c7ea2a9a9b0462347d967b5d138d41227;p=gnome-shell.git

popupMenu: Use SEPARATOR a11y role for SeparatorMenuItems

SeparatorMenuItems are not activatable, so SEPARATOR is a more
appropriate role than MENU_ITEM.

This is also what GTK3 does with GtkSeparatorMenuItem.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3773>
---

diff --git a/js/ui/popupMenu.js b/js/ui/popupMenu.js
index 39f6d7802..a068ced5e 100644
--- a/js/ui/popupMenu.js
+++ b/js/ui/popupMenu.js
@@ -308,6 +308,7 @@ class PopupSeparatorMenuItem extends PopupBaseMenuItem {
         this.label = new St.Label({text: text || ''});
         this.add_child(this.label);
         this.label_actor = this.label;
+        this.accessible_role = Atk.Role.SEPARATOR;
 
         this.label.connect('notify::text',
             this._syncVisibility.bind(this));